Difference between revisions of "Completed Proposal: Improvements to Scrubbing - Phase-2"

From Audacity Wiki
Jump to: navigation, search
(1422: I now agree with Gale that this could be closed as WONTFIX)
(Proposed Feature: I think we have covered 2.1)
Line 16: Line 16:
 
** [http://wiki.audacityteam.org/wiki/Talk:Proposal:_Improvements_to_Scrubbing_-_Phase-2#Steve.27s_Alternative_Solution:_Scrub_Toolbar_.28scrub_ruler.29 Scrub Toolbar] An additional "toolbar", similar to the Timeline, but dockable above or below the track window. Docking the toolbar above the track window allows quick and convenient switching between "Quick Play" and "Scrubbing", while docking at the bottom allows quick and convenient switching between scrubbing and scrolling.  
 
** [http://wiki.audacityteam.org/wiki/Talk:Proposal:_Improvements_to_Scrubbing_-_Phase-2#Steve.27s_Alternative_Solution:_Scrub_Toolbar_.28scrub_ruler.29 Scrub Toolbar] An additional "toolbar", similar to the Timeline, but dockable above or below the track window. Docking the toolbar above the track window allows quick and convenient switching between "Quick Play" and "Scrubbing", while docking at the bottom allows quick and convenient switching between scrubbing and scrolling.  
 
** <strike>[http://wiki.audacityteam.org/wiki/Talk:Proposal:_Improvements_to_Scrubbing_-_Phase-2#Alternative_Solution:_Scrub_tool Scrub Tool] This is much like how other audio software works for scrubbing. </strike>
 
** <strike>[http://wiki.audacityteam.org/wiki/Talk:Proposal:_Improvements_to_Scrubbing_-_Phase-2#Alternative_Solution:_Scrub_tool Scrub Tool] This is much like how other audio software works for scrubbing. </strike>
***'''Peter 19Aug16:''' We now have the Scrub Bar button (in the Scrub Toolbar which is now hidden by default), this can be used to turn the Scrub Bar on and off. The Scrub Bar is also off by default - but there is an outstanding enhancement request [http://bugzilla.audacityteam.org/show_bug.cgi?id=1485 Bug #1485] for it to be changed to  be "on" by default. The Scrub Bar can be right-clicked to invoke the scrubbing dropdown menu.  When scrubbing is taking place we still carry the green playhead icon in the Timeline  and this indicates to the user that scrubbing is a form of playing and thus they should realize that to stop scrubbing they simply have to press the Stop button or use one of its shortcuts: spacebar of Shift+A (for Stop & set cursor).  The user can also use the ESC key to escape from scrubbing while retaining their previous cursor position or selection.<p>With the Scrub Toolbar and the Scrub Bar both of by default Scrubbing is a little hard to find - only discoverable in the Transport menu with its Scrubbing entry and sub-entries.</p>
+
***'''Peter 21Aug16:''' The Scrub Bar is now "on" by default (with the Scrub Toolbar "off" by default).  The Scrub BAr can be toggled on/off from the right-click dropdown menu from the Timeline.
 +
***#The Scrub Bar can be right-clicked to invoke the scrubbing dropdown menu.  When scrubbing is taking place we still carry the green playhead icon in the Timeline  and this indicates to the user that scrubbing is a form of playing and thus they should realize that to stop scrubbing they simply have to press the Stop button or use one of its shortcuts: spacebar of Shift+A (for Stop & set cursor).  The user can also use the ESC key to escape from scrubbing while retaining their previous cursor position or selection.  
 +
***#There is also an entry in the Transport menu for Scrubing which can enable Scrubbing or seeking and also toggle the Scrub Bar on/off. 
 +
***#The Scrub Toolbar, hidden by default, is not really necessary to effect scrubbing of seeking, but users who discover it can deploy it and use it if they wish.<p>This should make the new Scrubbing in 2.1.3 much more "discovearble" and encourage exploration and use.</p>
  
  

Revision as of 11:10, 21 August 2016

Proposal pages help us get from feature requests into actual plans. This page is a proposal to improve Scrubbing in Audacity.
Proposal pages are used on an ongoing basis by the Audacity development team and are open to edits from visitors to the wiki. They are a good way to get community feedback on a proposal.


  • Note: Proposals for Google Summer of Code projects are significantly different in structure, are submitted via Google's web app and may or may not have a corresponding proposal page.


The Problem

There is no GUI method (button or menu command) to enter scrubbing mode, only a mouse and keyboard gesture which makes it hard to be "discoverable".

Proposed Feature

Phase-2 will address the UI and how the user accesses scrubbing, that will be harder than the Phase-1 cleanup and should only be undertaken once Phase-1 is complete.

This will involve a lot more discussion I'm thinking.

  • Peter 11Aug16: It certainly did ;-)))

2.1) It should be possible to access scrubbing, and escape from it, via a clear GUI. (i.e. keyboard shortcut or (ctrl)(shift)mouse-click on track don't count). The current solution is undiscoverable. You wouldn't guess that there was a scrubbing feature from looking at the track.

  • Peter 18Jan16: towards the end of the discussion on the Talk page Steve made two concrete proposals, I could support either of those:
    • Scrub Toolbar An additional "toolbar", similar to the Timeline, but dockable above or below the track window. Docking the toolbar above the track window allows quick and convenient switching between "Quick Play" and "Scrubbing", while docking at the bottom allows quick and convenient switching between scrubbing and scrolling.
    • Scrub Tool This is much like how other audio software works for scrubbing.
      • Peter 21Aug16: The Scrub Bar is now "on" by default (with the Scrub Toolbar "off" by default). The Scrub BAr can be toggled on/off from the right-click dropdown menu from the Timeline.
        1. The Scrub Bar can be right-clicked to invoke the scrubbing dropdown menu. When scrubbing is taking place we still carry the green playhead icon in the Timeline and this indicates to the user that scrubbing is a form of playing and thus they should realize that to stop scrubbing they simply have to press the Stop button or use one of its shortcuts: spacebar of Shift+A (for Stop & set cursor). The user can also use the ESC key to escape from scrubbing while retaining their previous cursor position or selection.
        2. There is also an entry in the Transport menu for Scrubing which can enable Scrubbing or seeking and also toggle the Scrub Bar on/off.
        3. The Scrub Toolbar, hidden by default, is not really necessary to effect scrubbing of seeking, but users who discover it can deploy it and use it if they wish.

          This should make the new Scrubbing in 2.1.3 much more "discovearble" and encourage exploration and use.


2.2) If mouse position is used to drag playback, there could be some tangible widget to be dragged. However this goes against 2.5) which seeks to make the drag less physical effort. Therefore an alternative could be to have the playhead widget not as the dragger but only as the up (off) /down (on) control to initiate scrubbing. If there is no drag widget then some option is needed to keep scrubbing alive when the playhead reaches the pointer.

  • Details: Where would the widget go? On the playhead, in the Timeline, or below it? We don't have many options for modified Timeline clicks - we already use CTRL and SHIFT with drag in the Timeline for Cut Preview and Loop Play respectively.
    • Peter 11Aug16: We have the draggable green widget(s) in the Scrub Bar or Timeline in 2.1.3 alpha now.


2.3) Scrubbing should work in all tools. (see also bug 1079). Scrubbing should fully enable those tools.

  • Note: The current implementation of scrubbing is a significant regression on the erstwhile waveform Quick-Play in that scrubbing does not allow the user to independently modify the cursor or selection while scrubbing. Possibly scrubbing can be enhanced enough that Quick-Play as a separate feature is no longer needed.
    • Peter 05Oct15: I would want to hold fire on thinking about losing Quick-Play from the Timeline - it is a very useful feature that I find myself using all the time.
    • Gale 06Oct15: Me too, but that's mainly because I find the current scrubbing hard to use/too much mental and physical effort.
      • Peter 08May16: Done. Scrubbing is now agnostic as to which tool is active and the user can even change tools while scrubbing is active and playing. And note that Paul's implementation of Scrubbing Phase-2 leaves Timeline Quick-play intact as it was and does not interfere with it - plus is is easy to switch between Scrubbing and Quick-Play at will.


2.4) Where should the cursor rest after scrubbing is stopped?

  • Peter 08May16: Current thinking in discussion on quality email thread seems to be that the cursor should be repositioned at the scrubbing stop position when scrubbing is stopped.
    • Peter 11Aug16: This has been implemented for 2.1.3, when you stop Scrubbing or Seeking with the Scrub Toolbar Buttons or the Stop button (or its shortcut) the cursor is moved to the current Scrub/Seek position. You can retain your previous cursor position or selction by using the Esc (Escape) key to stop Scrub/Seek.


2.5) Reduced physical effort to use scrubbing

  • Peter 11Aug16: I think that with Phase-2 as it stands now we have possibly/probably addressed Gale's misgivings in this regard

Outstanding issues

We should at least be attempting to fix the P2s and the P3s for the upcoming 2.1.3 release:

1053

P3 Status Bar messages incomplete for scrub started with menu or shortcut.

  • Fixed by James
    • Peter: tests ok on Mac and W10 when using the Transport Menu and when using the buttons in the Scrub Toolbar and when using the Scrub Bar. And I'm happy with the wording as it is now.
      • Reopened by Gale - but James comments that it works for him (on Windows)

1456

P5 Scrub Bar tooltip is incorrect on mouse down because there is no separate tooltip for that state

  • Fixed by James
    • on Mac & W10 messages ok on mouse down and then mouse up - but when moving in the Scrub Bar the Scrub tooltip incorrectly shows "Hide Scrub Bar"
      • reworked by James - needs retesting
        • Tests perfectly ok on W10. But on Mac I'm still seeing the incorrect "Hide Scrub Bar" tooltip when I'm hovering over the Scrub Bar after initiating a Scrub or Seek.

          Rather than changing this Bug as James suggest should we not instead be opening a new Mac bug for this?

          Bug #1477 created

1477

P4 (should probably be P3 and release noted) Mac: Sticky Tooltips

1419

P4 Confusing and unnecssary widget change when clicking in Scrub Bar

  • Fixed by James
    • On W10 and Mac El Cap behaviour is correct as per James' revised expected steps
      • Further changes and corrections made by James - need testing (not on 14Aug nightlies)

1422

P4 Changing to temporary seeking from Scrub Bar does not activate the seek button

  • Gale suggests marking this WONTFIX
    • Peter: This is somewhat less of an issue now that we have the Scrub Toolbar "off" by default. Many/most users will not "discover" the Scrub Toolbar so thay will never encounrer this. Plus the Scrub Toolbar is potentially subject to removal or radical change in Phase-3. So now I aggeee with Gale's suggestion to close this as WONTFIX

1475

P4 Enh: Default shortcuts for Scrub and Seek

  • Peter: I suggest S and Alt+S (Option+S on Mac) - both are currently unused
    • James wrote on Bugzilla: Demoting to P5. Users can set their own shortcuts, and there is disagreement about whether defaults should be set.

1423

P4 Click & drag in the Scrub Bar should invoke scrubbing not seeking

  • James demoted this to P5 - Gale repromoted it to P4
    • Peter: I think it is more important than that - it would give us "traditional scrubbing"

1476

P3 Horizontal Scroll serves no useful purpose when Scrubbing or Seeking

  • Promoted from P4 to P3 (and placed on RM's watch-list)

1478

P3 Cannot generate or record after starting and stopping Scrub Mode with no audio present

1487

P4 Scrub and Seek are enabled when there is no audio to operate on

1479

P4 Scrubbing buttons or menus do not change Scrubbing type if transport is not initiated

966

P3 Enh: Effortful/unintuitive to scroll-scrub at 1x speed without mousewheel or from start/end of project

  • reopened by Gale

1481

P4: Clicking the Scrub or Seek button twice corrupts Selection Start and Audio Position

  • Gale states: I would expect this to happen with the current behaviour. It happens with using the same menu item or shortcut twice too.

Outstanding issues - tested ok On W10 and Mac awiting Linux test and resolving

1451

P2 On Mac the background of the Pinned/Unpinned button is not the same color as the Timeline

  • James wants to close this as NOT_A_BUG: "Using the same style of button as elsewhere makes it very clear on Mac that this is a button. That seems good to me. In fact on windows we want the button to look more buttony."
    • Peter: I agree
      • James has worked on this - needs to be tested
        • Tests ok on W10 and Mac El Cap

1421

P3 When Scrubbing the Play button in the Transport Toolbar should not change its icon

  • Fixed by James
    • On Mac & W10 the icon does not change, correct.

1414

P4 Green triangles in scrub bar sometimes appear and sometimes don't

  • Peter: I still get this consistently on both my W10 laptop and my Macbook Pro El Capitan
    • Peter 21Aig16: without any explicit fix being made for this bug, it now tests ok on W10 and MAc El Capitan

Developer/QA Backing

  • Gale: Phase 1 is only really sticking plaster. We should move from Phase 1 to Phase 2 quickly. My feeling is that relatively few users are using scrubbing, and perhaps not all are finding it as useful as it could be. In contrast to the many user comments welcoming real-time preview, there seem to have been few comments about scrubbing, except for those falling into it by accident. Considering how popular scrubbing was as a feature request, this seems odd to me.
  • Peter 17Jan16: +1, I would prefer to see a scrub tool (ideally an extra button on the Transport toolbar, with a pre-assigned shortcut). Select the "scrub tool". Click and drag. Playback commences from the click position in the direction of the drag. Playback stops when the mouse button is released. Simple, effective, "does what it says on the tin".

Use Cases

  • As we already know from a posting on the Forum we have already had one poor benighted user who stumbled into scrubbing mode by mistake and then couldn't find his /her way out. See: this Forum thread
  • And see this Forum thread for another example of a confused user who wants to scrub, has read the Manual - but is still stuck.

Details

TBP


GUI Examples

TBP

Previous Feature Requests relating to this proposal

Not applicable.