Difference between revisions of "GitHub Pull Requests"

From Audacity Wiki
Jump to: navigation, search
(More clarity about labels.)
(Added ednote query about milestone link. Added to Category:For Developers)
Line 12: Line 12:
  
 
==Milestones==
 
==Milestones==
 
+
{{ednote|'''Gale 20Sep16:''' Should the link not be [https://github.com/audacity/audacity/milestone/1 1st January 2020 FAKE MILESTONE]? }}
 
We have one milestone:
 
We have one milestone:
  
Line 18: Line 18:
 
[http://wiki.audacityteam.org/w/index.php?title=Github_Pull_Requests 1st January 2020 FAKE MILESTONE]
 
[http://wiki.audacityteam.org/w/index.php?title=Github_Pull_Requests 1st January 2020 FAKE MILESTONE]
  
This isn't a milestone.  It's a way to tell people making any decent sized pull requests to please come over talk with us at the audacity devel email list.  If you just rely on the GitHub pull request messages, you may find we ignore or close the pull request for what does not seem to you to be a good reason.  Please come and talk.
+
This isn't a milestone.  It's a way to tell people making any decent sized pull requests to please come over talk with us at the audacity-devel email list.  If you just rely on the GitHub pull request messages, you may find we ignore or close the pull request for what does not seem to you to be a good reason.  Please come and talk.
  
 
There is a bit more  on our wiki about how we use these pull requests.
 
There is a bit more  on our wiki about how we use these pull requests.
Line 81: Line 81:
 
| Like the feature, but implementation not completed.
 
| Like the feature, but implementation not completed.
 
|}
 
|}
 +
 +
[[Category:For Developers]]

Revision as of 01:39, 12 September 2016


If you want a pull request to be acted on, do not rely on the GitHub pull request tracker.
For anything that is more than a couple of lines, you will almost certainly need to talk with us on audacity-devel mailing list.

Labels

We have these possible labels:

  • nice idea - We like the idea. This is neither positive nor negative about the implementation of the idea. We might not have reviewed or tried out the implementation yet.
  • who can test? - This PR is not being progressed for want of someone to try it out, e.g different platform to most developers, or it is using non standard hardware. Talk with us!
  • do we want this? - Do we like the sound of this feature as described? If our answer is yes, request becomes 'nice idea'. If no, thanks but no thanks.
  • lib-src or nyquist - This PR is about 'issues' with upstream code. Closing these pull requests generally requires communication upstream. Nyquist is easiest as upstream is in-house. Other ones likely will take longer. It's why we don't fix warnings on lib-src code.

Milestones

Gale 20Sep16: Should the link not be 1st January 2020 FAKE MILESTONE?

We have one milestone:


1st January 2020 FAKE MILESTONE

This isn't a milestone. It's a way to tell people making any decent sized pull requests to please come over talk with us at the audacity-devel email list. If you just rely on the GitHub pull request messages, you may find we ignore or close the pull request for what does not seem to you to be a good reason. Please come and talk.

There is a bit more on our wiki about how we use these pull requests.


Tables

  • Don't pay too much attention to the tables below.

On the way to being closed

Open requests that we are probably going to close soon, or at least we hope so. That could be close REJECT or close ACCEPT.

Pull Link By Comments
49 Run chain from command line Cory Cook Possibly an OK idea, but better done through using some of this code in scripting?
xx Add consts in FFmpeg Max Kellermann row 2, cell 3
75 Use noinst_SCRIPTS for toplevel audacity script 0-wiz-0 James hasn't much of a clue what this is about. It's short, and it looks like it should be a quick decision for someone who does know.


Closed but 'Nice Idea'

Closed pull requests that we want to look at again later. Possibly closed because either it or we are not ready for that pull request.

Pull Link By Comments
163 OpenMP TrackArtist::DrawSpectrum 3 times faster. Darrell Walisser Paul reviewed and was bothered mainly by changes which impact his as yet unmerged FishEye code. Hoping/expecting a resubmit.
135 Create a hidden configuration option to disable the save prompt on exit #135 Bracketcc The actual pull request is enormous, so something has gone wrong somewhere, and it wasn't pulled. Maybe look at #134 for the basic idea.
142 Parameter loading for batch EQ Wave Motion Like the feature, but implementation not completed.