Difference between revisions of "Patches Decided"
From Audacity Wiki
Galeandrews (talk | contribs) (Moving in #006 as now committed) |
Galeandrews (talk | contribs) (#007 committed) |
||
Line 23: | Line 23: | ||
|width="5%"| - | |width="5%"| - | ||
| [http://n2.nabble.com/Remaining-Debian-Ubuntu-patches-tp4097290p4097290.html Throw error if not all samples are written on export] | | [http://n2.nabble.com/Remaining-Debian-Ubuntu-patches-tp4097290p4097290.html Throw error if not all samples are written on export] | ||
− | | | + | |[http://code.google.com/p/audacity/source/detail?r=10283 Committed] by RA 20Feb10 |
|- | |- | ||
|width=5%|'''003''' | |width=5%|'''003''' | ||
Line 52: | Line 52: | ||
| [http://n2.nabble.com/Remaining-Debian-Ubuntu-patches-tp4097290p4097290.html SVG version of Audacity icon] | | [http://n2.nabble.com/Remaining-Debian-Ubuntu-patches-tp4097290p4097290.html SVG version of Audacity icon] | ||
| [http://code.google.com/p/audacity/source/detail?r=10281 Committed] by RA 20Feb10 | | [http://code.google.com/p/audacity/source/detail?r=10281 Committed] by RA 20Feb10 | ||
+ | |- | ||
+ | |width=5%|'''007''' | ||
+ | |Andrews, G. | ||
+ | |03Dec09 | ||
+ | || - | ||
+ | | [http://n2.nabble.com/Inverse-RIAA-patch-for-EQ-WAS-Re-code-and-translation-freeze-for-Audacity-1-3-10-beta-tp4105271p4105271.html Add Inverse RIAA to list of EQ curves] | ||
+ | | '''MJS:''' [http://code.google.com/p/audacity/source/detail?r=10284 Committed] an additional "Invert" button as a more general solution, but also [http://code.google.com/p/audacity/source/detail?r=10286 committed] the patch 22Feb10 to simplify negating RIAA. | ||
|- | |- | ||
|width=5%|'''008''' | |width=5%|'''008''' | ||
Line 93: | Line 100: | ||
{|class="gallery sortable" | {|class="gallery sortable" | ||
!No. !! Name !! class="unsortable"|Date !! Bug !! class="unsortable"|Details !! class="unsortable"|Comments | !No. !! Name !! class="unsortable"|Date !! Bug !! class="unsortable"|Details !! class="unsortable"|Comments | ||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
|- | |- | ||
|width=5%|'''012''' | |width=5%|'''012''' |
Revision as of 06:50, 22 February 2010
This is a page for archiving Patches that have been applied or rejected.
Contents
Patches Applied
No. | Name | Date | Bug | Details | Comments |
---|---|---|---|---|---|
001 | Tekumalla, L. | 18Nov09 | - | Timer Record needs to remember the last scheduled duration would not apply; EM made a working version to test | EM: See review. EM, GA, AWD and MJS all +1. RA: Replacement committed as r10282 20Feb10, re-write with far less code and more reliable. |
002 | Drung, B. | 03Dec09 | - | Throw error if not all samples are written on export | Committed by RA 20Feb10 |
003 | Drung, B. | 03Dec09 | - | Export Multiple: Consecutively numbered Label/Track Name | Committed by JKC 07Feb10, modifications committed by GA 10Feb10 |
004 | Drung, B. | 03Dec09 | - | Use "system" language, hide initial "Choose Language" dialogue | Committed by AWD 20Jan10 |
005 | Drung, B. | 03Dec09 | - | Protect against Pa_GetDeviceInfo returning null as per launchpad bug 436990 | Committed by AWD 20Jan10 |
006 | Drung, B. | 03Dec09 | - | SVG version of Audacity icon | Committed by RA 20Feb10 |
007 | Andrews, G. | 03Dec09 | - | Add Inverse RIAA to list of EQ curves | MJS: Committed an additional "Invert" button as a more general solution, but also committed the patch 22Feb10 to simplify negating RIAA. |
008 | Musgrove, E. | 14Dec09 | - | Allow narrower Meter Toolbar | Committed by JKC 06Feb10 |
009 | Musgrove, E. | 28Dec09 | - | Fix seek by character in Keyboard Preferences skipping one entry on Windows | Committed by MJS 30Dec09 |
011 | Musgrove, E. | 28Dec09 | - | Fix potentially off-screen slider knob labels on large monitors | Committed by MJS 29Dec09 |
017 | Musgrove, E. | 07Feb10 | - | Change title of (only) compressed file save dialog from "Save Project As..." to "Save Compressed Project As..." | Committed by JKC 07Feb10 |
018 | Musgrove, E. | 05Feb10 | - | One string needs to be translatable, also 3 used in scripting need a note that they should not be. | Committed by JKC 10Feb10 |
Patches Rejected
No. | Name | Date | Bug | Details | Comments |
---|---|---|---|---|---|
012 | Musgrove, E. | 28Dec09 | - | Fix typo in file filter | GA: Pipe symbol needed for proper filter display. Code now doesn't require pipe. |
013 | Musgrove, E. | 20Jan10 | Bug:71 | Resizable Export Multiple success dialog with vertical and horizontal scrollbars when needed. I think this new patch is very close if not final. |
JKC Way too much code for what it does, even after multiple attempts at this patch. Alternative solution used instead. |
014 | Musgrove, E. | 28Jan10 | Bug:20 | P3 Unreliable Automatic Crash Recovery | Ed My patch does not fix anything... |
016 | Musgrove, E. | 05Feb10 | - | Proposed new default shortcuts "E" for Export, "M" for Open Metadata Editor | GA: -1 for Metadata, it pops up by default on export. +1 for CTRL + SHIFT + E for Export if we keep the word. Keep unmodified shortcuts for truly repetitive actions. |