Difference between revisions of "ToDo: For DA Integration"

From Audacity Wiki
Jump to: navigation, search
(Many todos done.)
(More todos done.)
Line 6: Line 6:
 
* {{done}} Selection toolbar is inaccessible (does not respond to tabs normally and not read by Screen Readers)
 
* {{done}} Selection toolbar is inaccessible (does not respond to tabs normally and not read by Screen Readers)
 
::This is caused by theming the text.  The fix is to support color warping (on/off) as an option, on by default.  With color warping active, which will happen if the system theme is similar enough, Audacity will use the system settings for this control rather than faking it by new (colored) text items.  That will be OK for VI and HI-Contrast users.
 
::This is caused by theming the text.  The fix is to support color warping (on/off) as an option, on by default.  With color warping active, which will happen if the system theme is similar enough, Audacity will use the system settings for this control rather than faking it by new (colored) text items.  That will be OK for VI and HI-Contrast users.
 +
* {{todo}} On Linux there is no built in theme close enough to the default to allow color blending to work.
 +
:: This is what is still to do on [http://bugzilla.audacityteam.org/show_bug.cgi?id=1630 Bug 1630].  Will fix by reducing sensitivity.
 
* {{done}} On Linux Classic theme, the buttons are posterized
 
* {{done}} On Linux Classic theme, the buttons are posterized
 
:: This is caused by color warping from Windows default (bright) rather than from old default (darker).  It will be fixed by using a darker default in the theme and color warping that to light on Windows.
 
:: This is caused by color warping from Windows default (bright) rather than from old default (darker).  It will be fixed by using a darker default in the theme and color warping that to light on Windows.
 
* {{done}} In Hi-Contrast theme the meter numbers are the same color as the meter
 
* {{done}} In Hi-Contrast theme the meter numbers are the same color as the meter
 
:: The fix is (a) to detect this special case and (b) draw a contrasting background behind the numbers in that case.
 
:: The fix is (a) to detect this special case and (b) draw a contrasting background behind the numbers in that case.
 +
 
* {{done}} The pip on Mixer board is not rotated
 
* {{done}} The pip on Mixer board is not rotated
 
:: Will fix.  Wasn't a problem in DA which had a round pip.
 
:: Will fix.  Wasn't a problem in DA which had a round pip.
Line 18: Line 21:
 
* {{done}} Midi select color does not match wave select color.
 
* {{done}} Midi select color does not match wave select color.
 
:: Will fix.  
 
:: Will fix.  
* {{todo}} (reported) Sickly green colour for unused-track backgrounds in Classic theme on Mac.
+
* {{done}} TimeTrack background color does not match wave track background color.   
:: Cause unknown.   
+
:: Will fix.  
* {{todo}} (reported) Play cursor vanishes (except against waveform) in hi-contrast theme on Mac.
+
* {{done}} Color at right end of floating toolbars is always dark.
:: Need to check this.
 
* {{done}} Colour at right end of floating toolbars is always dark.
 
 
:: Will fix.
 
:: Will fix.
 
:::'''Gale 24Apr17:''' Replacing the resize handle with a black rectangle affects specifically "Classic" and "Light" Theme. It persists after restarting Audacity.  
 
:::'''Gale 24Apr17:''' Replacing the resize handle with a black rectangle affects specifically "Classic" and "Light" Theme. It persists after restarting Audacity.  
* {{todo}} Right end of floating toolbars not redrawn immediately after a theme change.
+
* {{done}} Right end of floating toolbars not redrawn immediately after a theme change.
:: Not clear why.  It's compounded by the bars themselves resizing but not their container.
+
:: Also some other parts of the frame were not always repainting.
 
+
* {{done}} Resizable floating toolbars shrink down to minimum size inside their frame, which stays the right size, on a theme change.
 +
:: Was not originally clear why.
  
 
* {{todo}} Toolbars lose their previous sizing, after visiting preferences and OKing.
 
* {{todo}} Toolbars lose their previous sizing, after visiting preferences and OKing.
 
:: Aim to fix this.
 
:: Aim to fix this.
* {{todo}} Tooltips for record-same-track and record-new-track don't update
+
 
:: Not a DA bug, but made more obvious by DA.  Fix to be done for both record and play.
 
* {{todo}} Old icon for record-append missing
 
:: Will re-instate as an option.
 
 
* {{done}} Note-tracks are not themed
 
* {{done}} Note-tracks are not themed
 
:: Will add an extra color for the zebra coloring.
 
:: Will add an extra color for the zebra coloring.
 
+
* {{done}} Spectrogram is not themed
* {{todo}} Spectrogram is not themed
 
 
:: Will at least use the background colors in future.
 
:: Will at least use the background colors in future.
 
* {{done}} Graph labels in 'Plot Spectrum' are too light (in dark theme)
 
* {{done}} Graph labels in 'Plot Spectrum' are too light (in dark theme)
 
:: Will fix.
 
:: Will fix.
 
  
 
* {{done}} The Light theme uses the 'cotton reel' images for pinned/unpinned.
 
* {{done}} The Light theme uses the 'cotton reel' images for pinned/unpinned.
Line 50: Line 47:
 
{{note|'''Peter 18Apr17:''' I think these cotton reel icons are more serious than a mere "niggle".  
 
{{note|'''Peter 18Apr17:''' I think these cotton reel icons are more serious than a mere "niggle".  
 
*'''Peter 19Apr17:''' Thanks for promoting this James.}}
 
*'''Peter 19Apr17:''' Thanks for promoting this James.}}
 +
 +
==Lower Priority Bugs==
 +
 +
* {{todo}} (reported) Sickly green color for unused-track backgrounds in Classic theme on Mac.
 +
:: Cause unknown. 
 +
* {{todo}} (reported) Play cursor vanishes (except against waveform) in hi-contrast theme on Mac.
 +
:: Need to check this.
 +
* {{todo}} Old icon for record-append missing
 +
:: Will re-instate as an option.
 +
* {{todo}} Tooltips for record-same-track and record-new-track don't update
 +
:: Not a DA bug, but made more obvious by DA.  Fix to be done for both record and play.
 +
* {{todo}} With big fonts (e.g. in Linux) the sizing looks messy.
 +
:: Not a DA bug, but would be nice to fix it.
  
 
==Improvement Requests==
 
==Improvement Requests==
Line 57: Line 67:
 
* {{done}} The time-text-control has lost the color distinction between numbers and units.
 
* {{done}} The time-text-control has lost the color distinction between numbers and units.
 
:: These colors need to be split.
 
:: These colors need to be split.
 +
 +
* {{done}} Naming of some items in rearranged menus 'not as previously agreed'.
 +
:: There may be mistakes in that, and even possibly something that was there is now missing.  A list here of the problem changes would help.  Some changes were made for consistency and have sound reasons/arguments for them.
 +
:::'''Gale 24Apr17:''' It was the change from Store/Retrieve cursor or selection to Save/Restore. I changed it back. 
 +
 +
==Lower Priority Improvement Requests==
 +
 
* {{todo}} Themes do not adapt (much) to system theme
 
* {{todo}} Themes do not adapt (much) to system theme
 
:: This is a big chunk of work, and won't be in 2.2.0.  It is most relevant to the Hi-Contrast theme where users may set individual colors for many aspects.  Doing this well entails extending the color warping.
 
:: This is a big chunk of work, and won't be in 2.2.0.  It is most relevant to the Hi-Contrast theme where users may set individual colors for many aspects.  Doing this well entails extending the color warping.
Line 63: Line 80:
 
* {{todo}} Meter numbers can't be switched on/off
 
* {{todo}} Meter numbers can't be switched on/off
 
:: Would be nice to have.
 
:: Would be nice to have.
* {{todo}} With big fonts (e.g. in linux) the sizing looks messy.
 
:: Not caused by DA, but would be nice to fix it.
 
  
* {{done}} Naming of some items in rearranged menus 'not as previously agreed'.
+
* {{todo}} The sync-lock icon has gone from the track display.
:: There may be mistakes in that, and even possibly something that was there is now missingA list here of the problem changes would helpSome changes were made for consistency and have sound reasons/arguments for them.
+
:: It does not need to be brought back, as the background change when there is a selection is enough, but if it is brought back it should do more than it did before - e.g. it should be a button to add/remove from sync-lock.
:::'''Gale 24Apr17:''' It was the change from Store/Retrieve cursor or selection to Save/Restore. I changed it back.
+
* {{todo}} Focus box invisible on buttons in darker themes.
 +
:: Probably outside our controlNeed to investigate.
 +
* {{todo}} Many corners of the interface are not themed.
 +
:: That is typically because they are controlled by the system themeThis has already been much improved by the blend-themes option, so that using Audacity with a system theme and related dark/light theme is better than it was.
 +
* {{todo}} Mute/Solo buttons do not have a hover effect.
 +
:: Not new.  Might fix some time.
 +
* {{todo}} ImageCache.png is confusing.
 +
:: It needs reorganising.
 +
* {{todo}} Dragger icons in ImageCache.png aren't used
 +
:: These are still owner-draw.
  
  
Line 75: Line 99:
 
* {{done}} Meter icons aren't actually buttons and highlight differently
 
* {{done}} Meter icons aren't actually buttons and highlight differently
 
:: Might fix some time.
 
:: Might fix some time.
* {{todo}} Mute/Solo buttons do not have a hover effect.
 
:: Not new.  Might fix some time.
 
* {{todo}} The sync-lock icon has gone from the track display.
 
:: If it is brought back it should do more than it did before.  It is easy to tell what mode one is in with a selection present.
 
* {{todo}} Focus box invisible on buttons in darker themes.
 
:: Outside our control.
 
* {{todo}} Many corners of the interface are not themed.
 
:: So work still to do.  Some will depend on using a system theme.  The main work of theming is on things we draw ourselves, such as the track panel and the html text.
 
* {{todo}} ImageCache.png is confusing.
 
:: It needs reorganising.
 
  
 
* {{done}} Blue background on Hi-Contrast theme selected track-panel-info reduces contrast.
 
* {{done}} Blue background on Hi-Contrast theme selected track-panel-info reduces contrast.
:: Instead the surrounds for buttons should be differentiated, and that will give greater clarity that the track is selected.  And a different selection colour used.
+
:: Instead the surrounds for buttons should be differentiated, and that will give greater clarity that the track is selected.  And a different selection color used.
 
* {{done}} Cyan selection in Hi-Contrast theme reduces contrast.
 
* {{done}} Cyan selection in Hi-Contrast theme reduces contrast.
 
:: This is tough.  Maybe a blue and not as saturated would work.
 
:: This is tough.  Maybe a blue and not as saturated would work.
 
* {{done}} RMS vs normal colors in Hi-Contrast theme reduces contrast.
 
* {{done}} RMS vs normal colors in Hi-Contrast theme reduces contrast.
:: Also tough, though a much bigger colour and brightness difference could be used.
+
:: Also tough, though a much bigger color and brightness difference could be used.
 
* {{done}} Circles are not centred in Hi-Contrast view
 
* {{done}} Circles are not centred in Hi-Contrast view
 
:: Hi-Contrast was originally done as a proof of concept.  Can be fixed later.
 
:: Hi-Contrast was originally done as a proof of concept.  Can be fixed later.
 
* {{todo}} Dragger icons in ImageCache.png aren't used
 
:: These are still owner-draw.
 
 
* {{done}} Separate image for rotated pip for slider on Mixer board.
 
* {{done}} Separate image for rotated pip for slider on Mixer board.
 
:: The shadow should be below, not above, so can't just rotate the normal pip.
 
:: The shadow should be below, not above, so can't just rotate the normal pip.

Revision as of 20:49, 27 April 2017

This page is for keeping track of bugs in Dark Audacity integration into 2.2.0 development build.
  • I'm hoping it will reduce the overhead in tracking bugs and requests for improvements

Bugs

  • Done.png Selection toolbar is inaccessible (does not respond to tabs normally and not read by Screen Readers)
This is caused by theming the text. The fix is to support color warping (on/off) as an option, on by default. With color warping active, which will happen if the system theme is similar enough, Audacity will use the system settings for this control rather than faking it by new (colored) text items. That will be OK for VI and HI-Contrast users.
  • ToDo.png On Linux there is no built in theme close enough to the default to allow color blending to work.
This is what is still to do on Bug 1630. Will fix by reducing sensitivity.
  • Done.png On Linux Classic theme, the buttons are posterized
This is caused by color warping from Windows default (bright) rather than from old default (darker). It will be fixed by using a darker default in the theme and color warping that to light on Windows.
  • Done.png In Hi-Contrast theme the meter numbers are the same color as the meter
The fix is (a) to detect this special case and (b) draw a contrasting background behind the numbers in that case.
  • Done.png The pip on Mixer board is not rotated
Will fix. Wasn't a problem in DA which had a round pip.
  • Done.png Mac buttons in dark theme don't look good.
Will fix.
  • Done.png Mac buttons in high contrast theme aren't high contrast buttons.
Will fix.
  • Done.png Midi select color does not match wave select color.
Will fix.
  • Done.png TimeTrack background color does not match wave track background color.
Will fix.
  • Done.png Color at right end of floating toolbars is always dark.
Will fix.
Gale 24Apr17: Replacing the resize handle with a black rectangle affects specifically "Classic" and "Light" Theme. It persists after restarting Audacity.
  • Done.png Right end of floating toolbars not redrawn immediately after a theme change.
Also some other parts of the frame were not always repainting.
  • Done.png Resizable floating toolbars shrink down to minimum size inside their frame, which stays the right size, on a theme change.
Was not originally clear why.
  • ToDo.png Toolbars lose their previous sizing, after visiting preferences and OKing.
Aim to fix this.
  • Done.png Note-tracks are not themed
Will add an extra color for the zebra coloring.
  • Done.png Spectrogram is not themed
Will at least use the background colors in future.
  • Done.png Graph labels in 'Plot Spectrum' are too light (in dark theme)
Will fix.
  • Done.png The Light theme uses the 'cotton reel' images for pinned/unpinned.
Will be fixed as part of other work.
  • ToDo.png The Dark theme uses the 'cotton reel' images for pinned/unpinned.
Will be fixed as part of other work.
Peter 18Apr17: I think these cotton reel icons are more serious than a mere "niggle".
  • Peter 19Apr17: Thanks for promoting this James.

Lower Priority Bugs

  • ToDo.png (reported) Sickly green color for unused-track backgrounds in Classic theme on Mac.
Cause unknown.
  • ToDo.png (reported) Play cursor vanishes (except against waveform) in hi-contrast theme on Mac.
Need to check this.
  • ToDo.png Old icon for record-append missing
Will re-instate as an option.
  • ToDo.png Tooltips for record-same-track and record-new-track don't update
Not a DA bug, but made more obvious by DA. Fix to be done for both record and play.
  • ToDo.png With big fonts (e.g. in Linux) the sizing looks messy.
Not a DA bug, but would be nice to fix it.

Improvement Requests

  • Done.png The ruler bar color can not be controlled independently of one of the selection colors
These colors need to be split.
  • Done.png The time-text-control has lost the color distinction between numbers and units.
These colors need to be split.
  • Done.png Naming of some items in rearranged menus 'not as previously agreed'.
There may be mistakes in that, and even possibly something that was there is now missing. A list here of the problem changes would help. Some changes were made for consistency and have sound reasons/arguments for them.
Gale 24Apr17: It was the change from Store/Retrieve cursor or selection to Save/Restore. I changed it back.

Lower Priority Improvement Requests

  • ToDo.png Themes do not adapt (much) to system theme
This is a big chunk of work, and won't be in 2.2.0. It is most relevant to the Hi-Contrast theme where users may set individual colors for many aspects. Doing this well entails extending the color warping.
  • ToDo.png Old themes not usable with new ImageCache layout.
It's possible using an old debug build with EXPERIMENTAL_THEMING_PREFS to export as separate images, and then re-import with the new code, saving some work.
  • ToDo.png Meter numbers can't be switched on/off
Would be nice to have.
  • ToDo.png The sync-lock icon has gone from the track display.
It does not need to be brought back, as the background change when there is a selection is enough, but if it is brought back it should do more than it did before - e.g. it should be a button to add/remove from sync-lock.
  • ToDo.png Focus box invisible on buttons in darker themes.
Probably outside our control. Need to investigate.
  • ToDo.png Many corners of the interface are not themed.
That is typically because they are controlled by the system theme. This has already been much improved by the blend-themes option, so that using Audacity with a system theme and related dark/light theme is better than it was.
  • ToDo.png Mute/Solo buttons do not have a hover effect.
Not new. Might fix some time.
  • ToDo.png ImageCache.png is confusing.
It needs reorganising.
  • ToDo.png Dragger icons in ImageCache.png aren't used
These are still owner-draw.


Niggles

  • Done.png Meter icons aren't actually buttons and highlight differently
Might fix some time.
  • Done.png Blue background on Hi-Contrast theme selected track-panel-info reduces contrast.
Instead the surrounds for buttons should be differentiated, and that will give greater clarity that the track is selected. And a different selection color used.
  • Done.png Cyan selection in Hi-Contrast theme reduces contrast.
This is tough. Maybe a blue and not as saturated would work.
  • Done.png RMS vs normal colors in Hi-Contrast theme reduces contrast.
Also tough, though a much bigger color and brightness difference could be used.
  • Done.png Circles are not centred in Hi-Contrast view
Hi-Contrast was originally done as a proof of concept. Can be fixed later.
  • Done.png Separate image for rotated pip for slider on Mixer board.
The shadow should be below, not above, so can't just rotate the normal pip.


With EXPERIMENTAL_DA

  • ToDo.png Mute/solo are stacked in wave-tracks but not note-tracks
Yep, ought to be made consistent. One thought is to use icons.
  • ToDo.png Dark logo 'vanishes' into background on a dark toolbar.
Needs e.g. a ring around it.