Difference between revisions of "ToDo: For DA Integration"
From Audacity Wiki
Galeandrews (talk | contribs) (Two comments by me) |
(Resize handle colour issue fixed.) |
||
Line 18: | Line 18: | ||
* {{todo}} (reported) Play cursor vanishes (except against waveform) in hi-contrast theme on Mac. | * {{todo}} (reported) Play cursor vanishes (except against waveform) in hi-contrast theme on Mac. | ||
:: Need to check this. | :: Need to check this. | ||
− | * {{ | + | * {{done}} Colour at right end of floating toolbars is always dark. |
:: Will fix. | :: Will fix. | ||
:::'''Gale 24Apr17:''' Replacing the resize handle with a black rectangle affects specifically "Classic" and "Light" Theme. It persists after restarting Audacity. | :::'''Gale 24Apr17:''' Replacing the resize handle with a black rectangle affects specifically "Classic" and "Light" Theme. It persists after restarting Audacity. | ||
+ | * {{todo}} Right end of floating toolbars not redrawn immediately after a theme change. | ||
+ | :: Not clear why. It's compounded by the bars themselves resizing but not their container, which is not a bug caused by DA. | ||
+ | |||
* {{todo}} Toolbars lose their previous sizing, after visiting preferences and OKing. | * {{todo}} Toolbars lose their previous sizing, after visiting preferences and OKing. |
Revision as of 21:42, 24 April 2017
This page is for keeping track of bugs in Dark Audacity integration into 2.2.0 development build.
- I'm hoping it will reduce the overhead in tracking bugs and requests for improvements
Bugs
-
Selection toolbar is inaccessible (does not respond to tabs normally and not read by Screen Readers)
- This is caused by theming the text. The fix is to support color warping (on/off) as an option, and with color warping on use the system settings for this control rather than faking it by new (colored) text items.
- This is caused by color warping from Windows default (bright) rather than from old default (darker). It will be fixed by using a darker default in the theme and color warping that to light on Windows.
- The fix is probably to draw a contrasting background behind the numbers. An alternative might be to use two colors, one for when over green, and one for when over black.
- Will fix. Wasn't a problem in DA which had a round pip.
- Will fix. Hi-Contrast will need custom buttons for Mac.
- Cause unknown.
- Need to check this.
- Will fix.
- Gale 24Apr17: Replacing the resize handle with a black rectangle affects specifically "Classic" and "Light" Theme. It persists after restarting Audacity.
- Will fix.
- Not clear why. It's compounded by the bars themselves resizing but not their container, which is not a bug caused by DA.
- Aim to fix this.
- Not a DA bug, but made more obvious by DA. Fix to be done for both record and play.
- Will re-instate as an option.
- Will add an extra color for the zebra coloring.
- Will at least use the background colors in future.
- Will fix.
- Will be fixed as part of other work.
Peter 18Apr17: I think these cotton reel icons are more serious than a mere "niggle".
- Peter 19Apr17: Thanks for promoting this James.
Improvement Requests
- These colors need to be split.
- These colors need to be split.
- This is a big chunk of work, and won't be in 2.2.0. It is most relevant to the Hi-Contrast theme where users may set individual colors for many aspects. Doing this well entails extending the color warping.
- It's possible using an old debug build with EXPERIMENTAL_THEMING_PREFS to export as separate images, and then re-import with the new code, saving some work.
- Would be nice to have.
- Not caused by DA, but would be nice to fix it.
- There may be mistakes in that, and even possibly something that was there is now missing. A list here of the problem changes would help. Some changes were made for consistency and have sound reasons/arguments for them.
- Gale 24Apr17: It was the change from Store/Retrieve cursor or selection to Save/Restore. I changed it back.
- There may be mistakes in that, and even possibly something that was there is now missing. A list here of the problem changes would help. Some changes were made for consistency and have sound reasons/arguments for them.
Niggles
- Might fix some time.
- Not new. Might fix some time.
- If it is brought back it should do more than it did before. It is easy to tell what mode one is in with a selection present.
- Outside our control.
- So work still to do. Some will depend on using a system theme. The main work of theming is on things we draw ourselves, such as the track panel and the html text.
- It needs reorganising.
- Instead the surrounds for buttons should become cyan, and that will give greater clarity that the track is selected.
- This is tough. Maybe a blue and not as saturated would work.
- Also tough, though a much bigger colour and brightness difference could be used.
- Hi-Contrast was originally done as a proof of concept. Can be fixed later.
- These are still owner-draw.
With EXPERIMENTAL_DA
- Yep, ought to be made consistent. One thought is to use icons.
- Needs e.g. a ring around it.