Difference between revisions of "User talk:PeterSampson/Sand-Box"

From Audacity Wiki
Jump to: navigation, search
(WIP ignore)
(wip ignore)
Line 5: Line 5:
 
! scope="col" width="160" |Analysis
 
! scope="col" width="160" |Analysis
 
|----
 
|----
| AudacityApp.cpp(706):
+
| Open Project
| MRUOpen(name); // FIX-ME: Check the return result?
+
|
| In disabled code.
+
|
 
|----
 
|----
| AudacityApp.cpp(761):
+
| Export 16-bit WAV
| // That itself may be a FIX-ME.
+
|
| OpenFile should return a status, and that status should be checked.
+
|  
 
|----
 
|----
| BatchCommands.cpp(437):
+
| Export 32-bit float WAV
| // FIX-ME: No error reporting on write file failure in batch mode.
+
|  
| Only affects batch mode.
+
|  
 
|----
 
|----
| BatchCommands.cpp(522):
+
| Export MP3 @192 JS cont
| //FIX-ME: for later versions may want to not select-all in batch mode.
+
|  
| But it is OK at the moment.
+
|  
 
|----
 
|----
| DirManager.cpp(843):
+
| Export AAC
| // FIX-ME: Might we get here without midkey having been set?
+
|  
| Indeed.  That would be worrying.  This function rebalances directory trees and needs very close scrutiny.  Possibly it's behind Bug 137.
+
|  
 
|----
 
|----
| Menus.cpp(1334):
+
| Amplify
| // FIX-ME: So we have a memory leak of menu items under linux?  Oops. 
+
|  
| It's not clear why windows needs to delete these menus and linux does not.
+
|  
 
|----
 
|----
| Project.cpp(2268):
+
| Noise Reduction
| // FIX-ME? This should return a result that is checked.
+
|  
| OpenFile should return a status.
+
|  
 
|----
 
|----
| Project.cpp(2355):
+
| Import 30 minute 16-bit WAV
| //FIX-ME: //v Surely we could be smarter about this,
+
|
| Coding style poor, but not apparently erroneous.
+
|  
 
|----
 
|----
| Resample.cpp(183):
+
| Import 30 minute 32-bit float WAV
| // FIX-ME: Audacity will hang after this if branch.
+
|  
| Serious, but only active if USE_LIBSAMPLERATE
+
|  
 
|----
 
|----
| TrackPanel.cpp(4813):
+
| Import 30 minute 192 MP3
| // FIX-ME: Disable this and return true when CutLines aren't showing?
+
|  
| Performance - mouse moves would be quicker with this fix.
+
|  
 
|----
 
|----
| TrackPanel.cpp(5175):
+
| Import 30 minute AAC
| //FIX-ME: Not necessarily. Haven't checked Track::Note (#if defined(USE_MIDI)).
+
|  
| MIDI and multi-tool mode probably don't get along because of this.
+
|  
 
|----
 
|----
| WaveTrack.cpp(2118):
+
| Save 30 minute imported project
| // FIX-ME: The track is now in an inconsistent state...
+
|  
| Looks serious, if using multiple sample rates.
+
|  
 
|----
 
|----
 
| effects\NoiseRemoval.cpp(193):
 
| effects\NoiseRemoval.cpp(193):

Revision as of 16:17, 31 March 2015

File (line) Comment Analysis
Open Project
Export 16-bit WAV
Export 32-bit float WAV
Export MP3 @192 JS cont
Export AAC
Amplify
Noise Reduction
Import 30 minute 16-bit WAV
Import 30 minute 32-bit float WAV
Import 30 minute 192 MP3
Import 30 minute AAC
Save 30 minute imported project
effects\NoiseRemoval.cpp(193): // FIX-ME: Should we check return value on Write? Cleanspeech profile does not flag error if can't write file.
export\ExportFFmpegDialogs.cpp(430): // FIX-ME: Catch XMLFileWriterException Writing presets does not check for file error.
export\ExportFFmpegDialogs.cpp(447): // FIX-ME: Catch XMLFileWriterException Reading presets does not check for file error.
widgets\Ruler.cpp(692): // FIX-ME: We don't draw a tick if of end of our label arrays Very minor.
widgets\Ruler.cpp(752): // FIX-ME: we shouldn't even get here if strPos < 0. Minor. Worst outcome if there is a problem would be missing ticks.
widgets\Ruler.cpp(804): // FIX-ME: We don't draw a tick if of end of our label arrays Cut and pasted code.
widgets\Ruler.cpp(866): // FIX-ME: we shouldn't even get here if strPos < 0. Cut and pasted code.
widgets\Ruler.cpp(981): // FIX-ME: Surely we do not need to allocate storage for the labels? Custom ruler annotation looks mildly expensive in terms of mallocs / frees.